Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all occurrences of illegal chars in the name var #291

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

gerases
Copy link

@gerases gerases commented Jul 13, 2023

Pull Request (PR) description

@gerases
Copy link
Author

gerases commented Jul 13, 2023

I'm not sure of the reason for the failed builds. It's not me right?

@smortex
Copy link
Member

smortex commented Jul 13, 2023

Debian 9 and Ubuntu 16.04 are EOL, you can ignore failures (if you want, you can rebase on top of master to integrate their removal):

From your working directory:

git fetch origin         # Download the latest code we have here
git rebase origin/master # Move your commits on top of the main branch
git push -f              # Send the changes (-f is required because you re-wrote history)

Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks reasonable.

@gerases gerases force-pushed the make-regsubst-global branch from 54e407c to 279dfd6 Compare July 13, 2023 20:04
@kenyon kenyon changed the title Replace all occurences of illegal chars in the name var Replace all occurrences of illegal chars in the name var Jul 13, 2023
@zilchms
Copy link
Contributor

zilchms commented Jan 26, 2024

Hey @gerases,
can you rebase this and fix the merge conflicts? :) If the CI passes then, I can merge it

@gerases gerases force-pushed the make-regsubst-global branch 3 times, most recently from b9831d2 to 5f95596 Compare January 26, 2024 16:41
@gerases
Copy link
Author

gerases commented Jan 26, 2024

@zilchms , done, let me know if you need me to do anything else

@bastelfreak bastelfreak added the bug Something isn't working label Jan 26, 2024
@bastelfreak bastelfreak merged commit 2db3fc5 into voxpupuli:master Jan 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants