Added Hiera support for postfix::config, postfix::hash, postfix::transport and postfix::virtual

[baurmatt]

This PR adds support for Hiera. Some dependency were removed since Puppet throw dependency cycle errors:

Class['postfix']

I not really sure if this will throw errors in some edge cases, i found none in my tests.

Class['postfix'] -> Postfix::Hash <| |>

No longer needed since dependency to class{ 'postfix': } is managed in hash.pp

[mcanevet]

create_resources should be done in postfix::config class

[baurmatt]

It can't be done in postfix::config since this is define type... My proposed way is the recommend way to implement hiera support.

[mcanevet]

Yes, you're right, not in postfix::config, in postfix::files.

[baurmatt]

But thats not the way other module work. I just want to do 'include postfix' and everything else is done in hiera. If i would implemented it that way you suggest, i would also need to do 'include postfix::files'. I don't see any benefit here.

[mcanevet]

No, postfix::files is included in init, so no need to include it afterwards.
Keep the params to init class like you did, but create the resources in postfix::files instead of in init this should fix the cyclic dependency.

[raphink]

@baurmatt Any news on this PR?

[raphink]

Will close this issue as no news have been provided in over 9 months.

[ubellavance]

@raphink What's the state of this PR. Does it need code or just testing? It would be very nice to have a postfix module that is entirely hiera-compatible.

[lingfish]

I agree... it was 90% there, not sure why the authors didn't just finish it off?

[ploeghvander]

Is there any development going on in this module? It looks quite dead.

[baurmatt]

I switched to https://github.com/thias/puppet-postfix

[ploeghvander]

ok. hmm last update 2 years ago

[baurmatt]

Better than 4 years, right? ;) I'm still using it for my server and it works so far. Hope thias might consider moving the module to Voxpupuli (thias/puppet-postfix#116)

[lingfish]

I've moved to Ansible :)

[mcanevet]

The latest release of this module was done a month ago so it's obviously not dead.

[finalhow]

I realize this issue is closed, but is there an example on how one can configure main.cf through postfix::files using Hiera?

[ubellavance]

@raphink could you re-open this issue? What does this PR needs?

Would you agree on moving this module to voxpupuli if you don't have much time for it anymore?

@finalhow I'm no expert, but here's what I did to enable hiera for some configs for the posgresql module'

  $configs=hiera('postgresql::server::config_entry', {})
  create_resources('postgresql::server::config_entry', $configs)

Then, I set the values I wanted this way:

postgresql::server::config_entry:
  max_wal_senders:
    value: '2'

  wal_level:
    value: 'hot_standby'

  archive_mode:
    value: 'on'

If I underestand correctly how it works, if you can set variables values in manifests, you can set variables values in hiera, once you've added the 2 lines above where you call your class (you'll obviously won't use the same names as me because it's not for the same context).

[finalhow]

@ubellavance Thanks, I will give that a try.

[ubellavance]

@finalhow if you need help, just post your config and I'll try to help.

[raphink]

@ubellavance I reopened the issue, but you have commit rights on the reporter's branch I guess, so it might still require to open a new one.

[raphink]

@ubellavance any news?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.