-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: store DMD hole position/dimensions with FullDMD / grill #70
Comments
In case of 2 screens the location might be in the backglass instead of the FullDMD eg: Checkpoint (Data East 1991) |
Sounds like a cool feature... but for the B2S Designer (as a first checkpoint) ? This way the directb2s files would get this information into it's xml structure. Something you would like to look into? |
Feel free to move this to the appropriate repo. |
Regarding looking into this I guess that's not doable on Linux/Mac? |
We can leave it here, cause we will need a change both here and in the Designer. So another issue on the Designer to make it possible to mark the DMD position.
You are right, it doesn't make it easier. I guess .NET isn't a blocker anymore, but these tools use Windows Forms for the GUI, so that isn't easy. I know there are users running the B2S Server on linux through Wine. |
@JockeJarre A Not saying that I will find the time to look into this as I have other higher priority standalone issues I would like to see fixed first. |
Good point! Done! |
I think it should be rather easy once the DMD can be set in the Designer, the calculation of the position is already handled by the Server. |
Personally I am mostly interested in the https://github.com/vpinball/vpinball/tree/standalone/standalone/inc/b2s |
ping @jsm174 |
Sorry, I'm not fully following. So we know the position of the B2S DMD window, but not the position of the VPinMAME or FlexDMD window inside the B2S DMD window. Or am I wrong on this? |
We want to know from the .directb2s file what the location of this dmd hole is so we can put the dmd automatically at the correct location. As you can see below these holes are not always the same size and at the same location Fulldmd with hole from Corvette Fulldmd from Black Rose with DMD at more or less correct location |
So that future version of the B2S.Server could potentially know where the DMD should be placed. Hopefully make a more seamless experience... |
Hi, |
If you want to make it as easy as possible, I would inspect the images for the full DMD and grill and then find the largest rectangle within the image, to automatically define the position. Se the image examples above... |
The simplest way is adding 2 relative coordinates to the xml. Other heuristics will be imprecise and slow down b2s startup. |
I completely agree that it's best to add coordinates in the xml. I would say: x,y,width and height. |
yes, sounds good! The B2S.Designer needs the possibility to mark the DMD position and save it in the directb2s file. Do not forget, two different DMD positions are needed. One for 2 screen cab with grill and one for 3 screen with full DMD. |
this is 100% needed and was quite surprised it wasnt added long ago. basic text in a location of the B2S that other apps can read... even if it need to be manually input (eg, not using the designer's GUI to find the coordinates) would be better than nothing. |
It is so good we are open source, just hack away! |
Must admit this whole resizing all my DMD's has gotten a bit 'stale'..... |
For 2 screen I would make an alternate proposal. The objective is to remove a few complex process from BG designer workload and at the same time standardize the output. That means that only by exception does the BG designer need to do any work related to the BG Grill - semi automated. In the B2S designer app, BG designer only has to pay attention to the BG image. No need to set Grill/DMD dimensions or include it in the BG image. As part of the BG design process the designer only has to "call out/declare" the required Grill and B2S will insert it automatically when B2S server runs that BG. B2S server should include default Grill image of each table brand, including a few generic Grills e.g. unbranded round speaker, unbranded rectangular speaker etc. All default Grills are designed to be same dimensions and all DMD in same position. |
Looks like something similar has been implemented by vpin studio. |
@Le-Syl21 wrote a tool to automate this |
I can confirm I did over a dozen tables now and its been spot on. I couldn't do it better by hand on standalone. Nice work and thanks for the great tool! |
To be complete, vpin studio also has this and uses a similar computer vision library |
Feature request
Let the b2s author indicate the location of the hole reserved for the DMD.
This would have to be a relative position so coordinates within the FullDMD window can be calculated from the actual window size.
eg:
On standalone we could then automatically place the DMD window relative to the FullDMD window.
The text was updated successfully, but these errors were encountered: