Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elasticmock doesn't support some elasticsearch_dsl features #60

Open
manalelidrissi opened this issue Jan 13, 2021 · 1 comment
Open

elasticmock doesn't support some elasticsearch_dsl features #60

manalelidrissi opened this issue Jan 13, 2021 · 1 comment

Comments

@manalelidrissi
Copy link

Hello all,

When I was introducing elasticmock for unit testing, I found out that it doesn't support the "must", "should" and "must_not" features of Elasticsearch_dsl.

Has anyone experienced this issue ? If so, What do you advise me to do ?
To the elasticmock team : Do you manage to resolve this issue on the next release ? For now, what's the alternative ?

Would be really grateful if you could help me move forward :)
@vrcmarcos
Copy link
Owner

It seems that MUST and SHOULD are already implemented, but MUST_NOT* is not (See here).

It seems an easy change, afaik. Wdyt of sending a PR with that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vrcmarcos @manalelidrissi