FakeQueryCondition._evaluate_for_range_query_type tries to isoparse a datetime object

[JimGomez48]

dateutil.parser.isoparse is meant to be used to transfrom ISO 8601 datetime strings into datetime objects. However, it is being used in FakeQueryCondition to parse a datetime object, which is both redundant and erroneous.

See https://github.com/vrcmarcos/elasticmock/blob/master/elasticmock/fake_elasticsearch.py#L179-L180

Proposal: Use a try/except block to try to parse the value. If exception on isoparse(), pass and continue.

[mRcSchwering]

I'm actually seeing the proble that doc_val stays a string for me in fake_elasticsearch:

          for sign, value in comparisons.items():
                if isinstance(doc_val, datetime.datetime):
                    value = dateutil.parser.isoparse(value)
                if sign == 'gte':
>                   if doc_val < value:
E                   TypeError: '<' not supported between instances of 'str' and 'datetime.datetime'

In the mapping the field is defined as {"type": "date"} and value seems to already be a datetime.datetime, but doc_val is still a string

[mRcSchwering]

I see FakeIndicesClient ignores body, so types have to be converted by hand before adding.
In case anyone stumbles across this as well.
I patched dateutil.parser.isoparse to achieve what @JimGomez48 was talking about:

def isoparse(arg):
    try:
        return dt.datetime.fromisoformat(arg)
    except TypeError:
        return arg

@pytest.fixture(autouse=True, scope="module")
def mocked_es():
    ELASTIC_INSTANCES.clear()
    patch_es = patch("elasticsearch.Elasticsearch", _get_elasticmock)
    patch_bug = patch("dateutil.parser.isoparse", isoparse)
    with patch_es, patch_bug:
        _setup_mocked_es()  # loads testdata
        yield