Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up old Thrift Client objects #2

Open
vrv opened this issue Nov 6, 2010 · 0 comments
Open

Clean up old Thrift Client objects #2

vrv opened this issue Nov 6, 2010 · 0 comments

Comments

@vrv
Copy link
Owner

vrv commented Nov 6, 2010

Following temporary thrift client creations (e.g., communicating between a joining node and an old tail to get updates), the current code does not delete the thrift client object used to communicate. It used to be done as follows

client->rpc_call(...);
delete client;

But this would result in segmentation faults, presumably because the rpc_call() code has some degree of asynchrony with respect to network sockets, etc. To ensure the system doesn't crash, we don't delete these temporary objects, but we should figure out 1) whether this is a thrift issue or 2) what we can do in our code to perform the cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant