Menu icon in mobile view jumps open->close

[heykapil]

No description provided.

[vsoch]

Yep reproduced! The trick will be comparing with https://fly.io/docs/ and figuring out what I stripped out that removed the functionality. I do remember testing it early on (and I think it worked) so likely I fussed something up.

[heykapil]

Our page is missing essential javascript functionality as https://fly.io/docs/ has. This minified javascript file has our required menu toggle, I'm talking about https://fly.io/public/javascripts/docs.js , but it includes several other things like js for algolia search and all.

[vsoch]

Thanks that's helpful! I must have removed it and not checked all functionality. I'm at work but will put in a PR later this evening to fix it up.

[vsoch]

okay @heykapil please test! #4

[heykapil]

Not working. Thanks for trying out ! I have removed extra code from https://fly.io/public/javascripts/docs.js to this https://imkapil.netlify.app/assets/js/menu.js
This worked for me. Please see it in action from any mobile device. https://imkapil.netlify.app

[vsoch]

Thats's weird, because it worked locally for me. Could you please open a PR with your fix for me to test?

[vsoch]

Also it works fine in my preview.... https://9-447414597-gh.circle-artifacts.com/0/tw-jekyll/docs/index.html

screen shot after I turned into mobile and clicked the menu. Are you sure you tested the right thing?

[heykapil]

Yup, menu is working in this https://9-447414597-gh.circle-artifacts.com/0/tw-jekyll/docs/index.html preview. Also, it is including algolia search engine for fly.io, look how search looks in desktop mode.

[vsoch]

ah that's the reason it's not working! Could you please provide that as clear feedback next time, because I was only looking at the explicit opening /closing of the menu and did not look at the search.

I've updated the PR and here is the new preview: https://10-447414597-gh.circle-artifacts.com/0/tw-jekyll/index.html

[heykapil]

Thanks @vsoch , Menu is working. Noticed in preview that menu button when clicked to expand items moves a bit left and when clicked to close menu items, it moves bit right Similar thing here https://imkapil.netlify.app/
Just this small tweak and this issue can be closed.

[vsoch]

I'm going to merge the PR since the issue is already present and the PR is an improvement, and if you have a suggested fix I'd be happy to test it out in another one. Thanks!

[vsoch]

It doesn't bother me that much, so I don't see actively working on it for a fix, but I will leave the issue open if others have suggestions. Thanks again!