Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PasswordGenerator should accept AllowedCharacterRule #40

Open
ememisya opened this issue Jun 29, 2016 · 1 comment
Open

PasswordGenerator should accept AllowedCharacterRule #40

ememisya opened this issue Jun 29, 2016 · 1 comment
Labels
enhancement

Comments

@ememisya
Copy link
Contributor

Currently the PasswordGenerator only takes a List of CharacterRule. It could benefit from also accepting CharacterCharacteristicsRule as well as AllowedCharacterRule as the two contain unique character pools, and it would also greatly improve interoperability with other classes such as the PasswordValidator (see ISSUE/39)
@amanvishnani
Copy link

It should also take IllegalCharacterRule, It will be a great improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ememisya @amanvishnani