From 8cb5c01dfd99f5974a1ef4792329621f50f68fa1 Mon Sep 17 00:00:00 2001 From: Iago Espinoza Date: Wed, 13 Nov 2024 14:33:48 -0300 Subject: [PATCH] fix: poor INP when opening drawer for the first time --- react/Drawer.tsx | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/react/Drawer.tsx b/react/Drawer.tsx index b0aaee5..ea3dd62 100644 --- a/react/Drawer.tsx +++ b/react/Drawer.tsx @@ -187,13 +187,17 @@ function Drawer(props: Props) { ) const overlayVisible = backdropMode === 'visible' && isMenuOpen - + useEffect(() => { - if (isMenuOpen || hasMenuBeenOpened || renderingStrategy === 'eager'){ + if (isMenuOpen || hasMenuBeenOpened || renderingStrategy === 'eager') { setShouldRenderChildren(true) } - }, - [hasMenuBeenOpened, renderingStrategy, setShouldRenderChildren, isMenuOpen]) + },[ + hasMenuBeenOpened, + renderingStrategy, + setShouldRenderChildren, + isMenuOpen + ]) return (