Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ideas for New Features #389

Open
OFSkean opened this issue Jul 30, 2024 · 4 comments
Open

Ideas for New Features #389

OFSkean opened this issue Jul 30, 2024 · 4 comments

Comments

@OFSkean
Copy link

OFSkean commented Jul 30, 2024

Hello! I'm a big fan of this library and have been using it in my research for over a year now. At this point, I have a fork with several new methods and some new features. I want to fold my changes back into the main repository, so are you still accepting new PRs?

New Methods:

New Features

  • Using the sampled augmentation parameters (like was_flipped or Gaussian blur strength) in the loss function. This is necessary for the AugSelf and Data Augmentation Disentanglement methods.
  • New evaluation metrics like RankMe, NCC and CDNV, and non-linear probe (MLP). Adding these metrics will be a nice complement to the standard linear probe evaluation.
@vturrisi
Copy link
Owner

Hey! Yes, please feel free to create PRs for the things that you have implemented. I currently don't have much time to implement new features, but I would be happy to review your PRs.

Note: create one separate PR for each feature so that it's easier for me to review the individual components.

@OFSkean
Copy link
Author

OFSkean commented Aug 3, 2024

Great! I'll try to submit a few PRs this weekend

@OFSkean
Copy link
Author

OFSkean commented Aug 4, 2024

Hey @vturrisi! I just submitted a PR here that implements FroSSL. I'll start with this one for now, and I'll do the others once I figure out how the CI and tests work. By the way, how do I run tests locally?

@vturrisi
Copy link
Owner

vturrisi commented Aug 6, 2024

Thanks, I'll check it in the course of this week.
To run the tests, you can do pytest --cov=solo tests/args tests/backbones tests/data tests/losses tests/methods tests/utils (simply doing pytest --cov=solo tests/ also works, but it will also run the dali tests). You will also need to install some libraries (pip install -e .[umap,h5] codecov mypy pytest-cov).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants