Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input type="number" v-model changes missing from migration guide #32

Open
dumbasPL opened this issue Jan 23, 2023 · 0 comments
Open

input type="number" v-model changes missing from migration guide #32

dumbasPL opened this issue Jan 23, 2023 · 0 comments

Comments

@dumbasPL
Copy link

In the Vue3 documentation, we can read that The number modifier is applied automatically if the input has type="number". This was not the case in Vue2. In Vue2 the value remained a string unless the .number modifier was used explicitly.

Related: vuejs/vue#12914

However, changing it in v2 would potentially break a lot of people’s code relying on this behavior

And not mentioning it in the migration guide will also break people's code. It's one of those things that you don't notice until you try to call a string function on a number and crash.

@skirtles-code skirtles-code transferred this issue from vuejs/docs Jan 24, 2023
Jinjiang pushed a commit that referenced this issue May 1, 2023
* feat: Ukrainian language

* feat: Migration build

* feat: Recommendations

* feat: Links, breaking changes page

* feat: global api

* fix: #9

* fix: #10 v-model

* #21 translate attr imcludes class and style

* #20 Translate: listeners are removed

* Update src/uk/breaking-changes/listeners-removed.md

* Update src/uk/breaking-changes/listeners-removed.md

* Update src/uk/breaking-changes/listeners-removed.md

* Update src/uk/breaking-changes/listeners-removed.md

* #19 Translate: Slots unification

* #18 Translate: render function API

* #28 Translate: PropsData

* #27 Translate:

* #27 Translate:

* #26 Translate: inline-template attribute

* #25 Translate: filters

* Update src/uk/breaking-changes/filters.md

* #24 Translate: events API

* #23 Translate: keycode modifiers

* Update src/uk/breaking-changes/keycode-modifiers.md

* Translate: custom elements interop

* Translate: custom directives #30

* Update src/uk/breaking-changes/custom-directives.md

Co-authored-by: Nazar Niphone <[email protected]>

* Update src/uk/breaking-changes/custom-directives.md

Co-authored-by: Nazar Niphone <[email protected]>

* Update src/uk/breaking-changes/custom-directives.md

Co-authored-by: Nazar Niphone <[email protected]>

* Update src/uk/breaking-changes/custom-directives.md

Co-authored-by: Nazar Niphone <[email protected]>

* translation improvements

* translate: key Attribute #11

* translate: v-bind merge behavior #13

* translate: v-if vs. v-for precedence #12

* translate: v-on.native modifier removed #14

* translate: title fix #14

* translate: functional components #15

* translate: async components #16

* translate: emits option #17

* translate: attribute coercion behavior #29

* translate: mount changes #32

* translate: props default this access #33

* translate: transition class change #34

* translate: transition as root #35

* translate: transition group root element #36

* translate: vnode lifecycle events #37

* translate: watch on arrays #38

* Update src/uk/breaking-changes/v-if-v-for.md

Co-authored-by: Olesya Kogivchak <[email protected]>

* Update src/uk/breaking-changes/v-if-v-for.md

Co-authored-by: Olesya Kogivchak <[email protected]>

* Update src/uk/breaking-changes/key-attribute.md

Co-authored-by: Olesya Kogivchak <[email protected]>

* Translate: data option

---------

Co-authored-by: olesyakogivchak <[email protected]>
Co-authored-by: Nazar Niphone <[email protected]>
Co-authored-by: Max Druzhinin <[email protected]>
Co-authored-by: Olesya Kogivchak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant