feat(theme): find best locale match to format last update #4360
+31
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the logic to find the best locale match from
navigator.languages
including:es-419
forceLocale
(per locale) and will returnundefined
(current logic) if not foundlang
attribute logicIntl.DateTimeFormat().resolvedOptions().locale
when best match not foundWhen testing this PR with Spanish, you should change replace
lang: 'es-CO',
withlang: 'es',
(using medium for time style, that's why we have the seconds in the screenshots below) in thees.ts
module.You can add the languages to your browser sorting them (at least on Chrome).
NOTE about using browser/OS default language:
english
page the text in english => no time lang attr (en
,en-GB
,en-US
should be present in languages)spanish
page withes-ES
=> time lang withes-ES
with proper format HH24 (es-ES
should be be present inlanguages)es-ES
afteres-AR
=> time lang withes-AR
with proper format AM/PM (es-ES
should be present in languages)pt
,jp
...) => using default browser/OS language, in my casees-ES
=> time lang withes-ES
with proper format HH24 (doesn't matter if I putes-AR
beforees-ES
)Linked Issues
Additional Context
Testing Intl.DateTimeFormat script
Spanish translation with es-AR
Spanish translation with es-ES
Tip
The author of this PR can publish a preview release by commenting
/publish
below.