Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPLD Block Explorer - Data cleanup June 24 2021 Sprint #45

Open
9 tasks done
stellarmagnet opened this issue Jun 28, 2021 · 4 comments
Open
9 tasks done

IPLD Block Explorer - Data cleanup June 24 2021 Sprint #45

stellarmagnet opened this issue Jun 28, 2021 · 4 comments
Assignees

Comments

@stellarmagnet
Copy link
Contributor

stellarmagnet commented Jun 28, 2021

Block Details

  • 0x needs to be added before the parent hash
  • 0x needs to be added after the "Hex: " in the Extra Data field
  • Remove the commas from the block number
  • It should say "Bytes" - it currently says "Byte" - the s is missing
  • The bytes seems incorrect by 7 bytes - see two examples below:

Example 1

https://rinkeby.etherscan.io/block/8845403
2,592 bytes

https://explorer.vdb.to/block/number/8845403
2,585 Byte

Example 2

https://rinkeby.etherscan.io/block/8845402
1,504 bytes

https://explorer.vdb.to/block/number/8845402
1,497 Byte

Transaction Details

Example 3

https://rinkeby.etherscan.io/tx/0x6e9b9df931e04c0bf196ed083648cd017d4b568e9611cac4c4a5d2cf6f79ce9e
https://explorer.vdb.to/tx/0x6e9b9df931e04c0bf196ed083648cd017d4b568e9611cac4c4a5d2cf6f79ce9e

Example 4

https://rinkeby.etherscan.io/tx/0xb9e08aa995bf2f2f2c601259f1c0dd32db2839385c4edb4595fb2ff267339700
https://explorer.vdb.to/tx/0xb9e08aa995bf2f2f2c601259f1c0dd32db2839385c4edb4595fb2ff267339700

@stellarmagnet
Copy link
Contributor Author

@ramilexe we need to also remove the commas from the block number - i just updated ticket

@ramilexe
Copy link
Contributor

ramilexe commented Jun 30, 2021

The bytes seems incorrect by 7 bytes - see two examples below

block RLP allocates additional bytes due to RLP design. we need to calculate it on eth-watcher-ts side

@ramilexe
Copy link
Contributor

Gas Used in transaction seems incorrect (compare the links in Examples 3 & 4 below)

RLP data contains CumulativeGasUsed so we need to derive GasUsed on eth-watcher-ts side

@ramilexe ramilexe self-assigned this Jun 30, 2021
@ramilexe
Copy link
Contributor

ramilexe commented Jul 7, 2021

PR: #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants