Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG | trycatch when re-downloading endpoint #11

Open
1 of 3 tasks
tin900 opened this issue Nov 6, 2024 · 0 comments
Open
1 of 3 tasks

BUG | trycatch when re-downloading endpoint #11

tin900 opened this issue Nov 6, 2024 · 0 comments
Assignees

Comments

@tin900
Copy link
Contributor

tin900 commented Nov 6, 2024

Issue Type

  • Bug Report
  • Feature Request
  • Question/Support

Current Behavior

The current implementation in scripts, checks only for missing course id's. However the endpoint calls may return an error, which is stored in the error columns. We need to also re-run those courses that had an error.

Expected Behavior

Re-run also erroneous courses.

Steps to Reproduce (for bugs)

Context

Your Environment

  • Version used:
  • Browser Name and version:
  • Operating System and version (desktop or mobile):
  • Link to your project:

Possible Solution

  error_courses <- dfEnrolments_filled %>%
    filter(!is.na(error)) %>%
    pull(course_id)
  
  df <- dfCourses %>%
    dplyr::filter(!id %in% dfEnrolments_filled$course_id | id %in% error_courses)

Screenshots

Additional Information

@tin900 tin900 self-assigned this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant