Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] download_filtered_tableau_image(): having certain special characters (e.g. :) in filter values causes error #10

Open
1 of 3 tasks
tkr231 opened this issue Sep 6, 2024 · 1 comment · May be fixed by #11
Open
1 of 3 tasks
Assignees
Labels
bug Something isn't working

Comments

@tkr231
Copy link

tkr231 commented Sep 6, 2024

Issue Type

  • Bug Report
  • Feature Request
  • Question/Support

Current Behavior

When a filter value contains any forbidden characters for filenames in windows (e.g. : or /) download_filtered_tableau_image() is unable to save the downloaded image

Expected Behavior

Ignore forbidden filename characters when trying to save the file. Make clear in the documentation that this theoretically could result
in overwriting already downloaded images, in case the only difference in filter values are the aformentioned characters.

Steps to Reproduce (for bugs)

  1. Supply a value with for instance ':' in the dataframe supplied at the df argument of the download_filtered_tableau_image() function

Context

See above.

Your Environment

vvtableau 0.6.0
R version 4.4.1

Possible Solution

Ignore forbidden filename characters when trying to save the file. Make clear in the documentation that this theoretically could result
in overwriting already downloaded images, in case the only difference in filter values are the aformentioned characters.

@tin900 tin900 self-assigned this Sep 9, 2024
@tin900 tin900 added the bug Something isn't working label Sep 9, 2024
@tin900
Copy link
Contributor

tin900 commented Sep 9, 2024

Hi @tkr231

It seems the issue arises from the underlying function row_to_name(). We could look into sanitizing the names by replacing such characters with an underscore.

You can test out the function on the associated branch for the changes. See also pull request #11

@tin900 tin900 linked a pull request Sep 9, 2024 that will close this issue
11 tasks
@tin900 tin900 linked a pull request Sep 9, 2024 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants