You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When a filter value contains any forbidden characters for filenames in windows (e.g. : or /) download_filtered_tableau_image() is unable to save the downloaded image
Expected Behavior
Ignore forbidden filename characters when trying to save the file. Make clear in the documentation that this theoretically could result
in overwriting already downloaded images, in case the only difference in filter values are the aformentioned characters.
Steps to Reproduce (for bugs)
Supply a value with for instance ':' in the dataframe supplied at the df argument of the download_filtered_tableau_image() function
Context
See above.
Your Environment
vvtableau 0.6.0
R version 4.4.1
Possible Solution
Ignore forbidden filename characters when trying to save the file. Make clear in the documentation that this theoretically could result
in overwriting already downloaded images, in case the only difference in filter values are the aformentioned characters.
The text was updated successfully, but these errors were encountered:
It seems the issue arises from the underlying function row_to_name(). We could look into sanitizing the names by replacing such characters with an underscore.
You can test out the function on the associated branch for the changes. See also pull request #11
Issue Type
Current Behavior
When a filter value contains any forbidden characters for filenames in windows (e.g. : or /) download_filtered_tableau_image() is unable to save the downloaded image
Expected Behavior
Ignore forbidden filename characters when trying to save the file. Make clear in the documentation that this theoretically could result
in overwriting already downloaded images, in case the only difference in filter values are the aformentioned characters.
Steps to Reproduce (for bugs)
Context
See above.
Your Environment
vvtableau 0.6.0
R version 4.4.1
Possible Solution
Ignore forbidden filename characters when trying to save the file. Make clear in the documentation that this theoretically could result
in overwriting already downloaded images, in case the only difference in filter values are the aformentioned characters.
The text was updated successfully, but these errors were encountered: