Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] improve typechecking of literal arrays as iterator in a for loop #3443

Closed
tserg opened this issue May 23, 2023 · 2 comments
Closed

[chore] improve typechecking of literal arrays as iterator in a for loop #3443

tserg opened this issue May 23, 2023 · 2 comments

Comments

@tserg
Copy link
Collaborator

tserg commented May 23, 2023

Version Information

  • vyper Version (output of vyper --version): 95bf73f
  • OS: linux
  • Python Version (output of python --version): 3.10.8

What's your issue about?

In vyper/semantics/analysis/local.py, the visit_For function can be improved by converting to a set() for literal arrays to prevent duplicates due to both SArrayT and DArrayT being present for the same base types.

h/t @trocher @ptrcarta

How can it be fixed?

Fill this in if you know how to fix it.
@charles-cooper charles-cooper changed the title chore: improve typechecking of literal arrays as iterator in a for loop [chore] improve typechecking of literal arrays as iterator in a for loop May 23, 2023
@charles-cooper charles-cooper mentioned this issue May 31, 2023
Closed
@charles-cooper
Copy link
Member

@trocher is this still an issue? as of c6b29c7

@trocher
Copy link
Contributor

trocher commented Feb 9, 2024

No, this is fixed as of #3596

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@charles-cooper @tserg @trocher