-
-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove folding #3709
feat: remove folding #3709
Conversation
…ctor/folding_alt2
…ctor/folding_alt2
…ctor/no_folding
# call `fold` for its typechecking side effects` | ||
try: | ||
self.fold(node) | ||
except UnfoldableNode: |
Check notice
Code scanning / CodeQL
Empty except Note
# exceptions other than `UnfoldableNode` to raise | ||
try: | ||
node.get_folded_value_throwing() | ||
except UnfoldableNode: |
Check notice
Code scanning / CodeQL
Empty except Note
from vyper.semantics.analysis.utils import ( | ||
check_modifiability, | ||
get_exact_type_from_node, | ||
validate_expected_type, | ||
) |
Check notice
Code scanning / CodeQL
Cyclic import Note
vyper.semantics.analysis.utils
constants[name] = val | ||
derived_nodes += 1 | ||
const_var_decls.remove(c) | ||
except UnfoldableNode: |
Check notice
Code scanning / CodeQL
Empty except Note
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3709 +/- ##
==========================================
+ Coverage 84.05% 84.12% +0.07%
==========================================
Files 92 93 +1
Lines 13045 13160 +115
Branches 2925 2943 +18
==========================================
+ Hits 10965 11071 +106
- Misses 1654 1656 +2
- Partials 426 433 +7 ☔ View full report in Codecov by Sentry. |
I ran into a few complications:
|
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture