Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify address.codehash for empty account #3711

Merged
merged 1 commit into from
Dec 27, 2023
Merged

docs: clarify address.codehash for empty account #3711

merged 1 commit into from
Dec 27, 2023

Conversation

pcaversaccio
Copy link
Collaborator

What I did

The EXTCODEHASH of an empty account is not empty(bytes32) but keccak256("") = 0xc5d2460186f7233c927e7db2dcc703c0e500b653ca82273b7bfad8045d85a470. See EIP-1052.

How I did it

Fixed the docs. Please note that there is no code bug, as any Vyper compiled contract will return 0xc5d2460186f7233c927e7db2dcc703c0e500b653ca82273b7bfad8045d85a470 for an EOA or an empty account (see here).

How to verify it

Commit message

docs: clarify `address.codehash` for an empty account

Description for the changelog

  • docs: clarify address.codehash for an empty account

Cute Animal Picture

image

@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2df916c) 84.02% compared to head (eed5a1e) 84.05%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3711      +/-   ##
==========================================
+ Coverage   84.02%   84.05%   +0.03%     
==========================================
  Files          92       92              
  Lines       13045    13045              
  Branches     2925     2925              
==========================================
+ Hits        10961    10965       +4     
+ Misses       1658     1654       -4     
  Partials      426      426              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pcaversaccio pcaversaccio self-assigned this Dec 26, 2023
@pcaversaccio pcaversaccio added the documentation Documentation label Dec 26, 2023
@fubuloubu fubuloubu merged commit bf26f83 into vyperlang:master Dec 27, 2023
84 checks passed
@pcaversaccio pcaversaccio deleted the patch-extcodehash-docs branch December 27, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants