Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat[venom]: stack2mem pass implementation #4245

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

feat[venom]: stack2mem pass implementation #4245

wants to merge 15 commits into from

Conversation

harkal
Copy link
Collaborator

@harkal harkal commented Sep 18, 2024 •
edited
Loading

What I did

Implemented the stack2mem pass. This pass demotes stack variables to memory accesses when they are not reachable on the stack.

Fixes [#4222]

How I did it

How to verify it

Commit message

This commit implements the `Stack2Mem` pass that converts stack variable to memory accesses.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@harkal
τεμπ
919346b 
temp

more stack2mem

exception and usage

mem allocator

tests and fixes to allocator

fixes

lint allocator

more

stack top method

allocator fixes

lint

fixes and update tests

plug memory allocator

add types

cleanup and lint

exceptions handling
@harkal
revert get_phi_depth() changes
f4c7ac5
@harkal
revert change that slipped in from another branch
cc50efe
@harkal
StackModel refactor
28eed40
@harkal harkal changed the title feat[venom]: stack2mem feat[venom]: stack2mem pass implementation Sep 24, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 18, 2024
View reviewed changes
vyper/venom/venom_to_assembly.py
elif opcode in ("alloca", "palloca"):
elif opcode == "alloca":
raise Exception("Alloca at assembly generation is not valid")
offset, _size = inst.operands

Check warning

Code scanning / CodeQL

Unreachable code Warning

This statement is unreachable.
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 22, 2024
View reviewed changes
vyper/venom/function.py
@@ -1,7 +1,9 @@
from typing import Iterator, Optional

from vyper.codegen.ir_node import IRnode
from vyper.venom.basicblock import IRBasicBlock, IRLabel, IRVariable
from vyper.utils import OrderedSet

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'OrderedSet' is not used.
vyper/venom/function.py
@@ -1,7 +1,9 @@
from typing import Iterator, Optional

from vyper.codegen.ir_node import IRnode
from vyper.venom.basicblock import IRBasicBlock, IRLabel, IRVariable
from vyper.utils import OrderedSet
from vyper.venom.basicblock import CFG_ALTERING_INSTRUCTIONS, IRBasicBlock, IRLabel, IRVariable

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'CFG_ALTERING_INSTRUCTIONS' is not used.
vyper/venom/function.py
@@ -1,7 +1,9 @@
from typing import Iterator, Optional

from vyper.codegen.ir_node import IRnode
from vyper.venom.basicblock import IRBasicBlock, IRLabel, IRVariable
from vyper.utils import OrderedSet
from vyper.venom.basicblock import CFG_ALTERING_INSTRUCTIONS, IRBasicBlock, IRLabel, IRVariable

Check failure

Code scanning / CodeQL

Module-level cyclic import Error

'IRBasicBlock' may not be defined if module
vyper.venom.basicblock
Loading
is imported before module
vyper.venom.function
Loading
, as the
definition
Loading
of IRBasicBlock occurs after the cyclic
import
Loading
of vyper.venom.function.
vyper/venom/function.py
@@ -1,7 +1,9 @@
from typing import Iterator, Optional

from vyper.codegen.ir_node import IRnode
from vyper.venom.basicblock import IRBasicBlock, IRLabel, IRVariable
from vyper.utils import OrderedSet
from vyper.venom.basicblock import CFG_ALTERING_INSTRUCTIONS, IRBasicBlock, IRLabel, IRVariable

Check failure

Code scanning / CodeQL

Module-level cyclic import Error

'IRLabel' may not be defined if module
vyper.venom.basicblock
Loading
is imported before module
vyper.venom.function
Loading
, as the
definition
Loading
of IRLabel occurs after the cyclic
import
Loading
of vyper.venom.function.
vyper/venom/function.py
@@ -1,7 +1,9 @@
from typing import Iterator, Optional

from vyper.codegen.ir_node import IRnode
from vyper.venom.basicblock import IRBasicBlock, IRLabel, IRVariable
from vyper.utils import OrderedSet
from vyper.venom.basicblock import CFG_ALTERING_INSTRUCTIONS, IRBasicBlock, IRLabel, IRVariable

Check failure

Code scanning / CodeQL

Module-level cyclic import Error

'IRVariable' may not be defined if module
vyper.venom.basicblock
Loading
is imported before module
vyper.venom.function
Loading
, as the
definition
Loading
of IRVariable occurs after the cyclic
import
Loading
of vyper.venom.function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charles-cooper charles-cooper charles-cooper left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harkal @charles-cooper