-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarification on ECDSA signatures #30
Comments
Yes, agreed that conformance is an issue. The real fix to this is that we need a test suite and test reports across implementations. We don't want to junk up the spec with tons of example tests (ECDSA is not the only one we'd want to cover). We have not made much progress on that over the past several years, but may be able to in the next six months or so since we've hired a few people to do just that. In the meantime, we'll track the issue here. Thanks for raising it, we'll do something about this in time. |
Can I use a bitcoin key pair for this ECDSA signature, which uses a fixed |
Yes, supporting the Secp256k1 curve is a design goal. We just need someone to contribute the implementation. @ejholmes -- also, we're currently developing a test suite to reduce the conformance problems you are noting. Development on the conformance test suite started last week... we expect the first pass to be done in a couple of weeks. We'll announce the test suite in issue #1 and request that implementations implement against that. |
Done. Thanks! |
We're big fans of HTTP Signatures at @remind101, and have recently contributed support for the
rsa-sha1
,rsa-sha256
andecdsa-sha256
algorithms in the Go version from 99designs: 99designs/httpsignatures-go#12The problem that we're seeing is that:
If you open https://tools.ietf.org/html/draft-cavage-http-signatures-10 in a browser, and search for "ecdsa", there's only one mention in Appendix E.:
Clicking through this brings you down to a link to the JWA RFC:
And finally, clicking through to this only links to the RFC, but not to the specific section (3.4) that specifies the ecdsa signature format.
I think it would be helpful if the HTTP Signatures RFC provided some test cases and examples for validating ECDSA signatures, like is done for RSA and HMAC in section 4.1.1 and section 4.1.2, respectively. This should include an ECDSA private key in PEM format, and an example signature that should verify with the public key, so that implementers can ensure proper conformance.
The text was updated successfully, but these errors were encountered: