Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a byte stream from "get stream" algorithm #188

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Conversation

saschanaz
Copy link
Member

@saschanaz saschanaz commented Jan 13, 2023

Closes #186

Paired with whatwg/fetch#1593.

For normative changes, the following tasks have been completed:

Implementation commitment:


Preview | Diff

Copy link
Collaborator

@mkruisselbrink mkruisselbrink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this lgtm

@saschanaz
Copy link
Member Author

(Ready to be merged as the Fetch one will be merged too as soon as Bikeshed issue is fixed)

@saschanaz saschanaz merged commit 5f1f9f5 into main Feb 17, 2023
@saschanaz saschanaz deleted the byte-reading branch February 17, 2023 14:48
github-actions bot added a commit that referenced this pull request Feb 17, 2023
SHA: 5f1f9f5
Reason: push, by saschanaz

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@jimmywarting
Copy link

Guess #83 can be closed too now that there is a byob support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Byte stream support for stream()?
3 participants