Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about the webschemas wiki #42

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Conversation

mattgarrish
Copy link
Member

@mattgarrish mattgarrish commented Feb 8, 2022

As requested in #29, this PR adds a new paragraph about the relationship to the webschemas wiki page to the note in the background section.


Preview | Diff

@madeleinerothberg
Copy link
Collaborator

New note looks great. There's a space between the link and the final period.

Copy link
Collaborator

@madeleinerothberg madeleinerothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The final page is rendering a space between the link and the final period, but I don't see it in the code. Mysterious.

@mattgarrish
Copy link
Member Author

Ya, I think it's just something weird with the way the diff is generated.

Looking at the source, it seems the diff version adds whitespace to the start and end of the p tag. That in turn appears to cause the period to get separated from the inline a tag as a new text string, so you wind up with a space before the period, too.

The preview doesn't have it and neither does the latest version, so I don't think it's anything we need to worry about.

@mattgarrish mattgarrish merged commit c122c35 into main Feb 9, 2022
@mattgarrish mattgarrish deleted the editorial/issue-29 branch February 9, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants