-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Section 7 S2S describes delivering activities to non-addressed actors? #478
Comments
Small tweaks to that final text...
|
I think one of the big problems with this section is the passive voice -- "Activities are sent", "recipients are determined". Changing these to use an active voice makes the responsibility more clear -- "Origin servers send activities" and "Origin servers determine the recipients." I think we can wordsmith this, taking @trwnh 's text as a basis, and making sure we remove the passive voice to make responsibilities more clear. |
I also think this architecture would benefit from a primer page describing how and when and by whom addressees are determined. |
An option we have is to amend the 2nd bullet point to |
I think the second bullet point may be a reference to inbox forwarding, since it is linked. If that is the case, it is a clumsy construction, but doesn't seem to be technically incorrect. |
At minimum we need to errata the text of the link to match the target of the link. It should not be |
Before:
After:
|
If we reduce the effort here to changing from "inbox delivery" to "inbox forwarding", I think it's much easier. I'll add an erratum for that issue. I think we still need to address the larger problem of specifying responsibility for determining recipients, but that may be something we can defer to primer pages or a next version or both. |
Here's the final text of the erratum:
This dodges a lot of the problems with the imprecise and perhaps confusing text, which may need separate errata or could be better written in a future version. |
as written, this implies that the activity will be delivered or distributed to actors who are not addressed on the activity, but are instead addressed on "the original object", which is a worrying concept.
the parenthetical links to the subsection on "inbox forwarding", but even in that case, the forwarding targets still need to be addressed explicitly on the activity.
proposed resolution
errata. this should not be stated in the spec as it is currently stated. if implemented as described, it would be a violation of expected behavior. tangentially, the bit about "following the appropriate links" could also be reworded to just explicitly calling out the addressing properties
final text for readability:
The text was updated successfully, but these errors were encountered: