Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sections 6.1 and 7 neglect to mention whether Announce activity requires object #479

Open
trwnh opened this issue Nov 6, 2024 · 2 comments
Labels
Needs Group Input/Decision Needs Primer Page Needs a page in the ActivityPub primer

Comments

@trwnh
Copy link

trwnh commented Nov 6, 2024

Servers performing delivery to the inbox or sharedInbox properties of actors on other servers MUST provide the object property in the activity: Create, Update, Delete, Follow, Add, Remove, Like, Block, Undo. Additionally, servers performing server to server delivery of the following activities MUST also provide the target property: Add, Remove.

i think an Announce without an object makes no sense, so this looks like a mistaken omission

proposed solution

errata. Add Announce to the list of activities requiring an object.

@evanp
Copy link
Collaborator

evanp commented Nov 15, 2024

Agreed, errata.

@evanp evanp added Needs Primer Page Needs a page in the ActivityPub primer Needs errata We need to add errata for this labels Nov 15, 2024
@trwnh trwnh changed the title Section 7 neglects to mention whether Announce activity requires object Sections 6 and 7 neglect to mention whether Announce activity requires object Jan 3, 2025
@trwnh trwnh changed the title Sections 6 and 7 neglect to mention whether Announce activity requires object Sections 6.1 and 7 neglect to mention whether Announce activity requires object Jan 3, 2025
@evanp
Copy link
Collaborator

evanp commented Jan 3, 2025

I added these two errata to the proposed list:

  • In Section 7 "Server to server interactions", the list of activities that require an object property should include the Announce activity.
  • In Section 6.1 "Client addressing", the list of activities that require an object property should include the Announce activity.

@evanp evanp added Needs Group Input/Decision and removed Needs errata We need to add errata for this labels Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Group Input/Decision Needs Primer Page Needs a page in the ActivityPub primer
Projects
None yet
Development

No branches or pull requests

2 participants