Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Section 6 on C2S does not describe side effects of Accept or Reject #489

Open
trwnh opened this issue Jan 14, 2025 · 2 comments
Open

Section 6 on C2S does not describe side effects of Accept or Reject #489

trwnh opened this issue Jan 14, 2025 · 2 comments
Labels
Needs errata We need to add errata for this Next version Normative change, requires new version of spec

Comments

@trwnh
Copy link

trwnh commented Jan 14, 2025

This came up in issue triage a few weeks ago but we seem to have forgotten to capture it? (I can't find a related issue, at least.)


S2S Accept describes receiving an Accept Follow in your inbox, which should add the actor to your following collection. But there is no language in C2S that describes Accept, or specifically that sending an Accept Follow should add that inner actor to your followers collection.

Likewise, S2S Reject describes how receiving a Reject Follow in your inbox MUST NOT result in adding that actor to your following collection, but there is no language in C2S that describes Reject, or specifically that sending a Reject Follow MUST NOT add that inner actor to your followers collection.

@evanp evanp added Next version Normative change, requires new version of spec Needs errata We need to add errata for this labels Jan 17, 2025
@evanp
Copy link
Collaborator

evanp commented Jan 17, 2025

Yes, I think it was an oversight to leave out Accept and Reject from the API section of the specification. IIRC, we originally expected that Follow would be a single activity, not requiring acceptance or rejection, and then added it due to implementation feedback. Since many implementers were using the protocol but not the API, I think we just added it to the server-to-server section.

I think if we are open to adding longer errata, it would make sense to add two subsections for Accept and Reject in section 6. If not, we should plan to expand this in the next version of ActivityPub.

@evanp evanp added Needs Primer Page Needs a page in the ActivityPub primer and removed Needs Primer Page Needs a page in the ActivityPub primer labels Jan 17, 2025
@evanp
Copy link
Collaborator

evanp commented Jan 17, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs errata We need to add errata for this Next version Normative change, requires new version of spec
Projects
None yet
Development

No branches or pull requests

2 participants