Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

selectAll command should be disabled if no selection exists on the context object #475

Open
gmta opened this issue Jan 20, 2025 · 0 comments
Open

selectAll command should be disabled if no selection exists on the context object #475

gmta opened this issue Jan 20, 2025 · 0 comments

Comments

@gmta
Copy link

gmta commented Jan 20, 2025

The spec for queryCommandEnabled states that all commands in the Miscellaneous section are always enabled. However, the steps for selectAll require that document.getSelection() does not return null. My suggestion is to disable the command whenever there is no selection available to work with.
gmta added a commit to gmta/ladybird that referenced this issue Jan 20, 2025
@gmta
LibWeb: Require existing Selection for .execCommand("selectAll")
ed5af22 
Disable the command if no selection is available. This is a spec bug:

w3c/editing#475

Fixes LadybirdBrowser#3325
@gmta gmta mentioned this issue Jan 20, 2025
Merged
gmta added a commit to gmta/ladybird that referenced this issue Jan 21, 2025
@gmta
LibWeb: Require existing Selection for .execCommand("selectAll")
4ae1651 
Disable the command if no selection is available. This is a spec bug:

w3c/editing#475

Fixes LadybirdBrowser#3325
tcl3 pushed a commit to LadybirdBrowser/ladybird that referenced this issue Jan 21, 2025
@gmta @tcl3
LibWeb: Require existing Selection for .execCommand("selectAll")
d967f56 
Disable the command if no selection is available. This is a spec bug:

w3c/editing#475

Fixes #3325
Psychpsyo pushed a commit to Psychpsyo/ladybird that referenced this issue Jan 23, 2025
@gmta @Psychpsyo
LibWeb: Require existing Selection for .execCommand("selectAll")
c6660a9 
Disable the command if no selection is available. This is a spec bug:

w3c/editing#475

Fixes LadybirdBrowser#3325
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gmta