Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should RTCRtpTransceiverInit have sendTransform and receiveTransform members? #221

Open
jan-ivar opened this issue Jan 8, 2024 · 0 comments

Comments

@jan-ivar
Copy link
Member

jan-ivar commented Jan 8, 2024

From @alvestrand in #186 (comment):

Actually addTransceiver() already takes an RTCRtpTransceiverInit with 3 existing members - adding a transform here would be consistent with the existing interface.

This seems reasonable and orthogonal to other discussions, so I'm opening this issue to discuss it. E.g. this:

const transceiver = pc.addTransceiver(track, {
  direction,
  streams,
  sendEncodings,
  sendTransform,
  receiveTransform
});

...would be equivalent to:

const transceiver = pc.addTransceiver(track, {sendEncodings});
transceiver.direction = direction;
transceiver.sender.setStreams(streams);
transceiver.sender.transform = sendTransform;
transceiver.receiver.transform = receiveTransform;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant