-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add fractionLost stats in RTCInboundRtpStreamStats #706
Comments
There are two ways of calculating fractionLost:
The (1) is already possible. For (2) the main issue is the timestamp reported in the object is based on the latest snapshot and not the timestamp when the RTCP RR was created. |
yes, we calc fractionLost via 1 before, but we think fractionLost is more important ,it should be in standard getStats :>. |
Curious why the measurement in (1) would not be sufficient? Especially, if the receiver is making a local decision based on the data that it can calculate. On further thought, one reason that I could see is if you want to correlate fractionLost received in RTCP RR at the sender (in inbound-remote, the same place we have roundTripTime) with what was measured at the receiver. For this case, I would need clarification from the current implementors-- does Chrome/Firefox keep a running counter for |
as title described: suggest add fractionLost stats in RTCInboundRtpStreamStats, as rtp receiver, fractionLost field exist in RTCP RR and is calculated every RTCP RR internal, we just need export it to RTCInboundRtpStreamStats.
just as fractionLost exist in rtcremoteinboundrtpstreamstats currently, it's filled via remote send RTCP RR. This is just a personal opinion on improve this stats, discuss the feasibility with you. |
Though it is a derived metric that can be calculated by other already reported metrics, as this field is already surfaced in other stats it makes total sense to add this field too in order to avoid ambiguity. Or destroy the current surfaced fractional loss metric. Either way, confusion should be avoided. |
Remote inbound is at the sender and based on receiving an RTCP RR, the object is only updated when the RTCP RR is received. So there's is no ambiguity on when the data in the object is updated. For exposing the stat on the receiver, it needs to be clarified when the fractionLost metric is updated, each time the snapshot is created, i.e., getStats() is called or when the RTCP RR is generated and sent. If it is the former, then yes -- adding the metric is fairly straightforward. However, if it's the latter, we will need to expose a rtcp send timestamp to indicate when the fractionLost metric was calculated. If there was other uses for the rtcpTimestamp, the case for the latter would indeed be more compelling. Is there a patch for exposing this metric in Chrome or Firefox? |
It seems there is no field describe packet loss rate of specfic audio/video inbound rtp stream,
the fractionLost field exist in RTCRemoteInboundRtpStreamStats, but it‘s about outbound loss rate.
packet loss rate is a common stats for rtc system,and it's calculated at rtp receiver(inbound), i think it’s necessary to import this to RTCinbounRtpStreamStats at rtp receiver side.
The text was updated successfully, but these errors were encountered: