Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update WPTs to not be kind-agnostic #707

Open
henbos opened this issue Oct 18, 2022 · 3 comments
Open

Update WPTs to not be kind-agnostic #707

henbos opened this issue Oct 18, 2022 · 3 comments
Labels
needs test Proposed Rec Blocker

Comments

@henbos
Copy link
Collaborator

henbos commented Oct 18, 2022

The current tests are happy with either video or audio metrics, but some are only defined for one of the kinds.

Having WPTs have separate tests for different kinds would help with #660, where we update the spec to say which kinds are defined for a metric.
@fippo
Copy link
Contributor

fippo commented Oct 19, 2022 •
edited
Loading

this mainly affects https://github.com/web-platform-tests/wpt/blob/master/webrtc-stats/supported-stats.https.html ?

@henbos
Copy link
Collaborator Author

henbos commented Oct 19, 2022

Yes!

@fippo
Copy link
Contributor

fippo commented Apr 23, 2024

This has been recently biting us for remote-outbound-rtp which has been showing up as implemented but was only implemented for audio, not video. Since fixed but...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs test Proposed Rec Blocker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fippo @henbos