Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no visibility #167

Open
ProCynic opened this issue Apr 16, 2012 · 6 comments
Open

no visibility #167

ProCynic opened this issue Apr 16, 2012 · 6 comments

Comments

@ProCynic
Copy link
Collaborator

need to implement some sort of visibility on all stuff.

@ProCynic
Copy link
Collaborator Author

this really touches on the data hierarchy we have. If we're going to call our top level postable thing Likeable, we need to pull the User owner and that sort of thing up to it.

@ProCynic
Copy link
Collaborator Author

using the check annotation of the secure module is more about controllers that models. I think the best option is probably to just add visibility to likeable, as painful as that refactor might be.

@ProCynic
Copy link
Collaborator Author

#219

@amshali
Copy link
Collaborator

amshali commented Apr 25, 2012

should we close this?

@ProCynic
Copy link
Collaborator Author

Not quite yet. We still need to actually use the visibility in appropriate
places. Basically anywhere a controller is doing a findAll it needs to be
replaced with find visible.
-Geoffrey Parker

On Tue, Apr 24, 2012 at 9:36 PM, Amin Shali <
[email protected]

wrote:

should we close this?


Reply to this email directly or view it on GitHub:
#167 (comment)

@amshali
Copy link
Collaborator

amshali commented Apr 26, 2012

Right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants