Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redundant M5L5 code #312

Open
aaronjfisher opened this issue Jun 26, 2020 · 1 comment
Open

redundant M5L5 code #312

aaronjfisher opened this issue Jun 26, 2020 · 1 comment

Comments

@aaronjfisher
Copy link

Hello,

This issue is based on something mentioned here

#305

g.getM5L5 is not called inside of g.part5. Rather, g.part5 seems to have additional code for M5L5. Suggesting to consolidate and use g.getM5L5 throughout, to make it easier to update and/or submit changes to each part.

Thanks!

@vincentvanhees
Copy link
Member

Thanks, I am a bit busy with other (paid) developments at the moment. Maybe later in the year. That said, pull requests are always welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants