Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple Waifu of the Day #161

Open
zaerald opened this issue Aug 22, 2020 · 2 comments
Open

Decouple Waifu of the Day #161

zaerald opened this issue Aug 22, 2020 · 2 comments
Assignees
Labels
type: enhancement Improvements
Milestone

Comments

@zaerald
Copy link
Member

zaerald commented Aug 22, 2020

No description provided.

@zaerald zaerald added the type: enhancement Improvements label Aug 22, 2020
@Unthrottled Unthrottled added this to the WMP v1.4 milestone Aug 29, 2020
@zaerald zaerald self-assigned this Oct 31, 2020
@zaerald
Copy link
Member Author

zaerald commented Nov 1, 2020

We should have a separate directory for waifu-of-the-day as this shouldn't show in the alert. On top of it, we need standard sizes for portrait and landscape Waifus, so we can have a consistent display for all assets. But it'll be better to have a separate ticket for it.

For the directory name, can day be fine? The expected dir structure would be:

.
└── waifuMotivationAssets/
    ├── audible
    ├── day
    ├── text
    ├── visuals
    └── assetChecks.json

@Unthrottled
Copy link
Member

🤔 Hmm, so the waifu of the day has 2 parts right? The waifu and then all the text stuff that goes below the waifu.

It makes sense, however, how the assets are managed, might need to changed a bit, both in this repository and in https://github.com/waifu-motivator/waifu-motivation-assets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvements
Projects
None yet
Development

No branches or pull requests

2 participants