Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance #11

Open
f3lang opened this issue Apr 24, 2018 · 3 comments
Open

Maintenance #11

f3lang opened this issue Apr 24, 2018 · 3 comments

Comments

@f3lang
Copy link
Collaborator

f3lang commented Apr 24, 2018

Hi @walling,

This project is right now the base for a least 3 published npm packages. rsvg, librsvg and librsvg-prebuilt.
The packages are quite similar (librsvg basically adding windows build functionality and some bugfixes and librsvg-prebuilt just adding prebuilts and also bugfixes).

Each package was released after the source of the fork was more or less abandoned. Right now this project has 6 open issues with the newest one older then 2 Years and one open pull request from 4 years ago.

The second project librsvg which started of at a pull request to this one here (the one open pr right now),
is also pretty inactive (project url: https://github.com/2gis/node-rsvg). Last comment on any issue or pr was 2 Years ago.

But since this project is quite useful and there are projects and developers using it, it would be great to merge the projects again into one and at least release the three packages again from one codebase and apply the open fixes.

So what my question ist: is this project still alive?

@walling
Copy link
Owner

walling commented Apr 24, 2018

I'm sorry to say that I don't have the time resources at the moment to revive this project. I'm happy to hand out some commit access to the repo + adding ownership in NPM. In this case, can you outline a plan how to move on?

@f3lang
Copy link
Collaborator Author

f3lang commented Apr 25, 2018

Ok, great. I think this would be the best way. I also got feedback from the owners of librsvg on this and they are also ok with it and already added me as an owner of the package.

I would suggest having two main packages in the end: rsvg and rsvg-prebuilt (the names are more convenient than librsvg). rsvg should be used in development context with existing build environments and rsvg-prebuilt for package dependencies. Both packages have the same source.

So my plan right now looks like this:

  • merge the three codebases back into one project (preferable this project here, since it is the original one) and publish a current version. I will still maintain the prebuilds in my repo since the publishing of the builds with travis and appveyor relies on the access to my s3 bucket. But the repo will just be a mirror.
  • clean up issues and merge open pr
  • Update repository (add contribution guidlines, pr and issue templates etc.)
  • Add a deprecation notice on librsvg and librsvg-prebuilt package description, mark the packages as deprecated in npm and get the dependent packages to move to rsvg/rsvg-prebuilt

In the long term i will consider something like this:

  • As long as there are active users on the libsvg and librsvg-prebuilt packages, still publish current versions (right now nearly all downloads and dependant packages are on those two packages).
  • After the traffic runs out and the dependant packages have migrated, abandon the librsvg and librsvg-prebuilt packages with a notice to use rsvg/rsvg-prebuilt.

What do you think?

@walling
Copy link
Owner

walling commented Jul 25, 2018

@f3lang Sorry for not responding for a long time. I didn't mean to shut you off, but I haven't really had the time to look into it.

I think your plan is good. If you still have an interest, I invited you to this repo as well as npm access. I think that should make it possible to get started. Let me know if there's anything I need to look into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants