Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated "Enable Legacy Oauth" section #35

Open
dregad opened this issue Mar 29, 2021 · 4 comments
Open

Duplicated "Enable Legacy Oauth" section #35

dregad opened this issue Mar 29, 2021 · 4 comments

Comments

@dregad
Copy link

dregad commented Mar 29, 2021

Describe the bug
In the Configuration dialog, the Enable Legacy Oauth 2.0 Credentials section is present under both the Sync Authorization and Options and Defaults tab

To Reproduce
Steps to reproduce the behavior:

  1. Go to Tools > KPSync > Configure
  2. Notice Legacy Oauth section at bottom
  3. Click on Options and Defaults tab
  4. Notice duplicated section

Expected behavior
Only a single occurence is required, or am I missing something ?

Screenshots
Unnecessary I guess, but if you need them let me know

Please complete the following information:

  • OS: Windows 10, version 1909 build 18363.1440
  • Browser N/A
  • Version 4.0.6-beta

Additional context
N/A

@dregad
Copy link
Author

dregad commented Mar 29, 2021

As a side note, when the Enable checkbox is not checked, the Help and Google Developer Console links at the bottom remain visible as non-actionable text. Maybe they should be hidden instead, to avoid confusion.

@walterpg
Copy link
Owner

The Options and Defaults tab contains controls for configuring plugin options affecting usage with all existing databases, and future databases. A user who wants to use the same personal OAuth 2.0 creds for every database created in the future, would enter those credentials there. If, on the other hand, a user wanted to change the personal OAuth 2.0 creds for the currently open database, they would use the similar controls of the Sync Authorization tab.

Given that personal OAuth 2.0 creds support is a DEPRECATED feature, perhaps the issue could be rephrased in those terms, e.g., "Remove deprecated features from 'Options and Defaults' configuration controls".

Anyone else interested in this feature/bug care to comment?

@dregad
Copy link
Author

dregad commented May 20, 2021

perhaps the issue could be rephrased in those terms, e.g., "Remove deprecated features from 'Options and Defaults' configuration controls".

Fine with me

Anyone else interested in this feature/bug care to comment?

Guess not 😉

@walterpg
Copy link
Owner

Anyone else interested in this feature/bug care to comment?

Guess not 😉

There is still interest in deprecated features (#42), however I don't think removing the "default for new databases" in this case would distract from that.

I could be mistaken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants