-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicated "Enable Legacy Oauth" section #35
Comments
As a side note, when the Enable checkbox is not checked, the Help and Google Developer Console links at the bottom remain visible as non-actionable text. Maybe they should be hidden instead, to avoid confusion. |
The Options and Defaults tab contains controls for configuring plugin options affecting usage with all existing databases, and future databases. A user who wants to use the same personal OAuth 2.0 creds for every database created in the future, would enter those credentials there. If, on the other hand, a user wanted to change the personal OAuth 2.0 creds for the currently open database, they would use the similar controls of the Sync Authorization tab. Given that personal OAuth 2.0 creds support is a DEPRECATED feature, perhaps the issue could be rephrased in those terms, e.g., "Remove deprecated features from 'Options and Defaults' configuration controls". Anyone else interested in this feature/bug care to comment? |
Fine with me
Guess not 😉 |
There is still interest in deprecated features (#42), however I don't think removing the "default for new databases" in this case would distract from that. I could be mistaken. |
Describe the bug
In the Configuration dialog, the Enable Legacy Oauth 2.0 Credentials section is present under both the Sync Authorization and Options and Defaults tab
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Only a single occurence is required, or am I missing something ?
Screenshots
Unnecessary I guess, but if you need them let me know
Please complete the following information:
Additional context
N/A
The text was updated successfully, but these errors were encountered: