From 86871189baad9404364cad25dd2d387c9a5fe252 Mon Sep 17 00:00:00 2001 From: Zachary Blasczyk Date: Wed, 15 Jan 2025 14:38:11 -0600 Subject: [PATCH 1/3] fix: Create Secrets --- charts/operator-wandb/Chart.yaml | 2 +- charts/operator-wandb/values.yaml | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/charts/operator-wandb/Chart.yaml b/charts/operator-wandb/Chart.yaml index ecc81d59..5e61b790 100644 --- a/charts/operator-wandb/Chart.yaml +++ b/charts/operator-wandb/Chart.yaml @@ -2,7 +2,7 @@ apiVersion: v2 name: operator-wandb description: A Helm chart for deploying W&B to Kubernetes type: application -version: 0.23.3 +version: 0.23.4 appVersion: 1.0.0 icon: https://wandb.ai/logo.svg diff --git a/charts/operator-wandb/values.yaml b/charts/operator-wandb/values.yaml index c83b6c34..1f90fe8b 100644 --- a/charts/operator-wandb/values.yaml +++ b/charts/operator-wandb/values.yaml @@ -794,6 +794,7 @@ settingsMigrationJob: - secrets verbs: - get + - create - list - update - patch From 6a926de16e09b89d3a73219e2129f81e1ef89ee4 Mon Sep 17 00:00:00 2001 From: Zachary Blasczyk Date: Wed, 15 Jan 2025 18:27:16 -0600 Subject: [PATCH 2/3] fix: prevent restarts --- charts/operator-wandb/Chart.lock | 10 +++++----- charts/operator-wandb/Chart.yaml | 2 +- charts/operator-wandb/values.yaml | 3 ++- charts/wandb-base/Chart.yaml | 2 +- charts/wandb-base/templates/job.yaml | 3 +++ 5 files changed, 12 insertions(+), 8 deletions(-) diff --git a/charts/operator-wandb/Chart.lock b/charts/operator-wandb/Chart.lock index 1245b0c1..805a20d5 100644 --- a/charts/operator-wandb/Chart.lock +++ b/charts/operator-wandb/Chart.lock @@ -4,7 +4,7 @@ dependencies: version: 0.1.0 - name: wandb-base repository: file://../wandb-base - version: 0.3.2 + version: 0.3.3 - name: console repository: file://charts/console version: 0.1.0 @@ -58,9 +58,9 @@ dependencies: version: 0.1.0 - name: wandb-base repository: file://../wandb-base - version: 0.3.2 + version: 0.3.3 - name: wandb-base repository: file://../wandb-base - version: 0.3.2 -digest: sha256:a2d3636ac4dee7fff70f4b166f4c73df6527d2180bbdb1eab4a82719eb78d7df -generated: "2025-01-14T21:56:01.76604-06:00" + version: 0.3.3 +digest: sha256:f4f9e1eba82917d816b21ff820453cd3c8515a79fd708072064915f2f5f6687e +generated: "2025-01-15T17:48:23.145862-06:00" diff --git a/charts/operator-wandb/Chart.yaml b/charts/operator-wandb/Chart.yaml index 5e61b790..c5eea8b6 100644 --- a/charts/operator-wandb/Chart.yaml +++ b/charts/operator-wandb/Chart.yaml @@ -2,7 +2,7 @@ apiVersion: v2 name: operator-wandb description: A Helm chart for deploying W&B to Kubernetes type: application -version: 0.23.4 +version: 0.23.5 appVersion: 1.0.0 icon: https://wandb.ai/logo.svg diff --git a/charts/operator-wandb/values.yaml b/charts/operator-wandb/values.yaml index 1f90fe8b..71040ecf 100644 --- a/charts/operator-wandb/values.yaml +++ b/charts/operator-wandb/values.yaml @@ -819,7 +819,8 @@ settingsMigrationJob: kind: Job jobs: smj: - ttlSecondsAfterFinished: 3600 + ttlSecondsAfterFinished: 60 + backoffLimit: 0 containers: smj: image: diff --git a/charts/wandb-base/Chart.yaml b/charts/wandb-base/Chart.yaml index 7e028322..0cb83907 100644 --- a/charts/wandb-base/Chart.yaml +++ b/charts/wandb-base/Chart.yaml @@ -2,7 +2,7 @@ apiVersion: v2 name: wandb-base description: A generic helm chart for deploying services to kubernetes type: application -version: 0.3.2 +version: 0.3.3 icon: https://wandb.ai/logo.svg maintainers: diff --git a/charts/wandb-base/templates/job.yaml b/charts/wandb-base/templates/job.yaml index 14227219..a5e7c9ed 100644 --- a/charts/wandb-base/templates/job.yaml +++ b/charts/wandb-base/templates/job.yaml @@ -13,6 +13,9 @@ spec: {{- with $job.ttlSecondsAfterFinished }} ttlSecondsAfterFinished: {{ . }} {{- end }} + {{- with $job.backoffLimit }} + backoffLimit: {{ . }} + {{- end }} template: metadata: {{- with $job.podAnnotations }} From 987a8dfcc119524c724ac70a2034a8b554e364be Mon Sep 17 00:00:00 2001 From: Zachary Blasczyk <77289967+zacharyblasczyk@users.noreply.github.com> Date: Wed, 15 Jan 2025 19:44:37 -0600 Subject: [PATCH 3/3] Update values.yaml The backoff of 0 won't template. --- charts/operator-wandb/values.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/operator-wandb/values.yaml b/charts/operator-wandb/values.yaml index 71040ecf..e739cc5b 100644 --- a/charts/operator-wandb/values.yaml +++ b/charts/operator-wandb/values.yaml @@ -820,7 +820,7 @@ settingsMigrationJob: jobs: smj: ttlSecondsAfterFinished: 60 - backoffLimit: 0 + backoffLimit: 1 containers: smj: image: