Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis Created Despite create_redis Set to False in GCP terraform module #185

Closed
vijay-wandb opened this issue Dec 4, 2024 · 3 comments
Closed
Assignees

Comments

@vijay-wandb
Copy link

No description provided.

@vijay-wandb vijay-wandb self-assigned this Dec 4, 2024
@vijay-wandb
Copy link
Author

Redis is being created even though create_redis is explicitly set to false in the deployment using the GCP Terraform module public-dns-with-cloud-dns.

Here’s the variable definition:

variable "create_redis" {
  default     = false
  description = "Boolean indicating whether to provision a Redis instance (true) or not (false)."
  nullable    = false
  type        = bool
}

The logic in the module at main.tf#L362 appears to cause the issue:

redis = { install = !var.create_redis }

@vijay-wandb
Copy link
Author

vijay-wandb commented Dec 4, 2024

pr
#186

@danielpanzella
Copy link
Contributor

The customer should be setting create_redis to true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants