Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor should use external props not internal state #16

Open
thecaddy opened this issue Feb 3, 2016 · 3 comments
Open

editor should use external props not internal state #16

thecaddy opened this issue Feb 3, 2016 · 3 comments

Comments

@thecaddy
Copy link

thecaddy commented Feb 3, 2016

This editor uses an internal state meaning it is always editable but it should be controlled by an external prop where the parent controls the value whether by store, state, or something else.

@zhaoyao91
Copy link

+1

1 similar comment
@owenhoskins
Copy link

+1

@shark0der
Copy link
Contributor

shark0der commented Jul 1, 2016

While it sounds logical it might be harder to implement it due to this: #30 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants