Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add version information to peers storage and remove it on old version detection #531

Closed
alexeykiselev opened this issue Aug 17, 2021 · 0 comments · Fixed by #532
Closed

[FEATURE] Add version information to peers storage and remove it on old version detection #531

alexeykiselev opened this issue Aug 17, 2021 · 0 comments · Fixed by #532
Assignees
@nickeskov
Labels
enhancement New feature or request

Comments

@alexeykiselev
Copy link
Member

Motivation and Purposes

Starting the node with different version of peers storage leads to the error:

ERROR	Failed to open or create peers storage: failed to load known peers from file "gowaves/testnet/peers_storage/peers_known.cbor": failed to unmarshall CBOR into *storage.knownPeers from file "gowaves/testnet/peers_storage/peers_known.cbor": cbor: cannot unmarshal map into Go value of type int64

By adding version information to the peers storage we could detect structure incompatibility and remove the storage.
@alexeykiselev alexeykiselev added the enhancement New feature or request label Aug 17, 2021
@nickeskov nickeskov linked a pull request Aug 19, 2021 that will close this issue
Added version information to peers storage. #532
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickeskov nickeskov

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added version information to peers storage. wavesplatform/gowaves
2 participants
@alexeykiselev @nickeskov