Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gzip/xz/bzip2 support for input #34

Merged
merged 2 commits into from
May 21, 2024
Merged

Conversation

sharkLoc
Copy link
Contributor

@sharkLoc sharkLoc commented May 21, 2024

  • Support for reading gzip, xz, and bzip2 compressed files
  • Combine the magic numbers and file extensions of the files to determine the compression type. Any condition that is true can be used to determine the file type
  • run chopper without any args will report Error: stdin not detected and exit

@JMencius
Copy link
Contributor

JMencius commented May 21, 2024

@wdecoster I tested the performance of this pull version against the last version I submitted also using DM.fastq.gz. The performance is comparable, differences within 3 seconds.

@sharkLoc
Copy link
Contributor Author

@JMencius ,Yes, this version only adds support for two additional compressed files (xz and bzip2), and fixes the problem that data will be lost when there are multiple members of GZ files

@sharkLoc
Copy link
Contributor Author

sharkLoc commented May 21, 2024

Hi @wdecoster, i did a test
step1:

build multiple members gz file ,testGC.fastq in test-data dir

gzip -c testGC.fastq testGC.fastq > mutl.fq.gz

step2:
run command
chopper -i mutl.fq.gz --mingc 0.5

output :

result in chopper 0.8.0: Kept 6 reads out of 11 reads

in this pr version: Kept 12 reads out of 22 reads

@wdecoster
Copy link
Owner

run chopper without any args will report Error: stdin not detected and exit

Do you mean this was an error that is now fixed? It still works on stdin, right?

@sharkLoc
Copy link
Contributor Author

sharkLoc commented May 21, 2024 via email

@wdecoster
Copy link
Owner

Awesome!

@wdecoster wdecoster merged commit 151fe32 into wdecoster:master May 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants