Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previously signed-in user's Contacts become visible to another user for a while #125

Open
weaponsforge opened this issue Apr 29, 2023 · 0 comments
Labels
bug Something isn't working ui ux polishing UI updates and optimizations for a smoother UX

Comments

@weaponsforge
Copy link
Owner

weaponsforge commented Apr 29, 2023

Description

The previously signed-out user's contacts list becomes visible for a split-second when another user signs-in on the same browser tab, or another browser tab.

We should not display another user's Contacts list to other users. We should either:

  • Clear all contacts cache on sign-out
  • Find ways to not render a previously signed-out user's Contacts to newly signed-in users

Steps to Reproduce

  1. Sign-in to https://weaponsforge.github.io/my-phonebook and create several Contacts.
  2. Sign-out
  3. Sign-in again to https://weaponsforge.github.io/my-phonebook using another account.
    • Take note, the first account's Contacts list flashes briefly in the newly signed-in user's /contacts page before getting replaced with the user's actual Contacts list

Please view the attached video of the bug for reference.

Video: Previously signed-in user's ([email protected]) Contacts list flashes briefly after another user ([email protected]) signs-in

cached-contacts.mp4
@weaponsforge weaponsforge added the ui ux polishing UI updates and optimizations for a smoother UX label Apr 29, 2023
@weaponsforge weaponsforge added the bug Something isn't working label Apr 29, 2023
@weaponsforge weaponsforge changed the title Clear all contacts cache on sign-out Previously signed-in user's Contacts becomes visible to another user for a while Apr 29, 2023
@weaponsforge weaponsforge changed the title Previously signed-in user's Contacts becomes visible to another user for a while Previously signed-in user's Contacts become visible to another user for a while Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui ux polishing UI updates and optimizations for a smoother UX
Projects
None yet
Development

No branches or pull requests

1 participant