-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[spike] Pull based model to get HelmRelease events #180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luizbafilho
commented
May 8, 2023
|
||
restConfigManager.Add("local", "", ctrl.GetConfigOrDie()) | ||
|
||
// promServer, err := server.NewPromotionServer( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add it back commented out just to make sure the webhook is not being used while I test it.
/make-pr-image |
/make-pr-image |
/make-pr-image |
/make-pr-image |
yiannistri
added a commit
to weaveworks/weave-gitops-clusters
that referenced
this pull request
May 15, 2023
Testing out spike for pipeline-controller using watchers (weaveworks/pipeline-controller#180). Must revert after demo.
/make-pr-image |
luizbafilho
changed the title
Add HelmReleases watcher
[spike] Pull based model to get HelmRelease events
Jul 7, 2023
This is superseded by #193. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is all about trying out a new way of getting events from HelmReleases. Instead of the old way where we used webhooks to get notified when something happened, we're going for a pull-based model.
The big idea here is to make our Pipeline configuration simpler. That means no more messing around with setting up notification-controller providers and alerts.
What's going on