You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Based on comments in the following PR, it was noted that there is a slight inconsistency between how object status messages are computed from object conditions in Explorer and in the non-Explorer frontend.
In Explorer, we usually return a message from the object's Ready condition, and if no Ready condition is available, then an empty string:
opudrovs
changed the title
align object messages across explorer and non-explorer UIs
Align object messages across Explorer and non-Explorer UIs
Dec 14, 2023
opudrovs
changed the title
Align object messages across Explorer and non-Explorer UIs
Align computing object status messages across Explorer and non-Explorer UIs
Dec 14, 2023
opudrovs
changed the title
Align computing object status messages across Explorer and non-Explorer UIs
Align object status messages across Explorer and non-Explorer UIs
Dec 14, 2023
Based on comments in the following PR, it was noted that there is a slight inconsistency between how object status messages are computed from object conditions in Explorer and in the non-Explorer frontend.
In Explorer, we usually return a message from the object's
Ready
condition, and if noReady
condition is available, then an empty string:weave-gitops-enterprise/pkg/query/configuration/objectkind.go
Line 367 in dbfa652
In the non-Explorer frontend we also try to return a message from a
Ready
condition first, but if noReady
condition is available, we might return messages from aFalse
condition or the messages from the first of object's conditions:https://github.com/weaveworks/weave-gitops/blob/cc3c17632334ffa56838c4765e68ce388bde6b2f/ui/components/KubeStatusIndicator.tsx#L64
AC
The text was updated successfully, but these errors were encountered: