Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not have cluster-wide RBAC granting read access to secrets #3961

Open
erikgb opened this issue Aug 22, 2023 · 0 comments
Open

Should not have cluster-wide RBAC granting read access to secrets #3961

erikgb opened this issue Aug 22, 2023 · 0 comments
Assignees
Labels

Comments

@erikgb
Copy link
Contributor

erikgb commented Aug 22, 2023

Problem

The Helm chart unconditionally grants needed (AFAIK) cluster-wide read access to secrets, and should be replaced with namespaced RBAC:

https://github.com/weaveworks/weave-gitops/blob/main/charts/gitops-server/templates/role.yaml#L18-L28

Would prevent read access cluster-wide.

Solution

Create a new Role in the namespace running ww-gitops with the secret read permissions and a role binding granting the new role to the ww-gitops SA. Remove access to secrets from the cluster role.

Additional context

@erikgb erikgb added the type/enhancement New feature or request label Aug 22, 2023
@yiannistri yiannistri self-assigned this Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants