Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

Simultaneous changes to machine config and Kubernetes version are ignored #263

Open
bboreham opened this issue Jul 8, 2020 · 0 comments

Comments

@bboreham
Copy link
Contributor

bboreham commented Jul 8, 2020

The controller checks if the Kubernetes version is different to that currently installed, and if so goes into a special path to run a kubeadm upgrade:

func (a *MachineController) kubeadmUpOrDowngrade(machine *clusterv1.Machine, node *corev1.Node, installer *os.OS,
k8sVersion, planJSON string, ntype recipe.NodeType) error {
b := plan.NewBuilder()
upgradeRes, err := recipe.BuildUpgradePlan(installer.PkgType, k8sVersion, ntype)

That code path then builds an upgrade plan using only the Kubernetes version, so, if something else changed in the machine spec at the same time that change will not be applied, it will get lost.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant