Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FetchEvent test that should reject none Uint8Array ReadableStream. #28203

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

yoichio
Copy link
Contributor

@yoichio yoichio commented Mar 24, 2021

Following whatwg/fetch#267,
passing such ReadableStream to a service worker should be rejected.

@foolip
Copy link
Member

foolip commented Mar 25, 2021

The wpt-chrome-dev-* CI failures here were likely due to #19360. A workaround was landed in #28238, so I'm closing and reopening to re-trigger the CI checks.

@foolip foolip closed this Mar 25, 2021
@foolip foolip reopened this Mar 25, 2021
@yoichio
Copy link
Contributor Author

yoichio commented Apr 5, 2021

Ping?

@annevk annevk merged commit 6b817d4 into web-platform-tests:master Apr 14, 2021
annevk pushed a commit to whatwg/fetch that referenced this pull request Apr 15, 2021
This change addresses the inconsistency discussed in #267 that a chunk type in a stream body on uploading to the network is limited to Uint8Array, but passing it to a service worker is not restricted. This change limits the latter as well.

Tests: web-platform-tests/wpt#28203.
@yoichio yoichio deleted the 267 branch April 21, 2021 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants