Update mutation event suppression for <details name> to revised spec rules. #42335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 4, 2023
…rules. The rules for mutation event suppression for <details name> were revised during the process of reviewing the spec PR, based on the discussion starting at whatwg/html#9400 (comment) . The updated spec says that mutation events are suppressed during the "ensure details exclusivity by closing other elements if needed" and "ensure details exclusivity by closing the given element if needed" algorithms. This updates the implementation and tests to follow that rule. (The "handling of insertion of elements into group" test is testing the case where the events were already suppressed.) This also renames the test to remove "tentative" from the name, since the spec PR is landed and the test is now (with this change) up-to-date with the spec. Bug: 1444057 Change-Id: I9078beeb3527f2515f6e10efbf93a94232221238 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4912273 Commit-Queue: David Baron <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1205367}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4912273
branch
from
a0a9fe7
to
a221fcd
Compare
|
Good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rules for mutation event suppression for <details name> were revised
during the process of reviewing the spec PR, based on the discussion
starting at
whatwg/html#9400 (comment) . The
updated spec says that mutation events are suppressed during the "ensure
details exclusivity by closing other elements if needed" and "ensure
details exclusivity by closing the given element if needed" algorithms.
This updates the implementation and tests to follow that rule. (The
"handling of insertion of elements into group" test is testing the case
where the events were already suppressed.)
This also renames the test to remove "tentative" from the name, since
the spec PR is landed and the test is now (with this change) up-to-date
with the spec.
Bug: 1444057
Change-Id: I9078beeb3527f2515f6e10efbf93a94232221238
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4912273
Commit-Queue: David Baron <[email protected]>
Reviewed-by: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1205367}