From e2f7125fe19fff9774c5ad8b1536d2efbb528a97 Mon Sep 17 00:00:00 2001 From: Giacomo Petri Date: Mon, 13 Jan 2025 09:44:36 +0100 Subject: [PATCH 1/9] Nested ARIA and HTML buttons - Presentational Roles Conflict Resolution --- ...le_none_conflict_resolution.tentative.html | 48 +++++++++++++++++++ 1 file changed, 48 insertions(+) create mode 100644 wai-aria/role/role_none_conflict_resolution.tentative.html diff --git a/wai-aria/role/role_none_conflict_resolution.tentative.html b/wai-aria/role/role_none_conflict_resolution.tentative.html new file mode 100644 index 00000000000000..ab2f1957cde54c --- /dev/null +++ b/wai-aria/role/role_none_conflict_resolution.tentative.html @@ -0,0 +1,48 @@ + + + + Role None Conflict Resolution Verification Tests + + + + + + + + + + +

ARIA role="button" nesting ARIA role="button" (no presentational roles conflict resolution, since not focusable)

+
+ outer button + Inner button +
+ + +

HTML button nesting HTML button

+
+ +
+ + + + + From 23c48534788155947883650ab869282d560c755c Mon Sep 17 00:00:00 2001 From: Giacomo Petri Date: Wed, 15 Jan 2025 23:15:40 +0100 Subject: [PATCH 2/9] Update wai-aria/role/role_none_conflict_resolution.tentative.html Co-authored-by: James Craig --- wai-aria/role/role_none_conflict_resolution.tentative.html | 1 - 1 file changed, 1 deletion(-) diff --git a/wai-aria/role/role_none_conflict_resolution.tentative.html b/wai-aria/role/role_none_conflict_resolution.tentative.html index ab2f1957cde54c..99b1cb8971ec90 100644 --- a/wai-aria/role/role_none_conflict_resolution.tentative.html +++ b/wai-aria/role/role_none_conflict_resolution.tentative.html @@ -10,7 +10,6 @@ -

ARIA role="button" nesting ARIA role="button" (no presentational roles conflict resolution, since not focusable)

From 5d2a636c4969d0aa1edc1b18a7dcb66c7c29a4fc Mon Sep 17 00:00:00 2001 From: Giacomo Petri Date: Wed, 15 Jan 2025 23:19:38 +0100 Subject: [PATCH 3/9] Update wai-aria/role/role_none_conflict_resolution.tentative.html Co-authored-by: James Craig --- wai-aria/role/role_none_conflict_resolution.tentative.html | 5 ----- 1 file changed, 5 deletions(-) diff --git a/wai-aria/role/role_none_conflict_resolution.tentative.html b/wai-aria/role/role_none_conflict_resolution.tentative.html index 99b1cb8971ec90..c7eb26aafac894 100644 --- a/wai-aria/role/role_none_conflict_resolution.tentative.html +++ b/wai-aria/role/role_none_conflict_resolution.tentative.html @@ -36,11 +36,6 @@

HTML button nesting HTML button

innerButton.id = "inner-button"; document.getElementById("inner-button-container").appendChild(innerButton); - promise_test(async t => { - const role = await test_driver.get_computed_role(document.getElementById('inner-button')); - assert_equals(role, "button"); - }, "test nested HTML button within HTML button"); - //https://github.com/web-platform-tests/interop-accessibility/issues/161 ends From 99d9117321b8cc6e7631db641fb71e196199770f Mon Sep 17 00:00:00 2001 From: Giacomo Petri Date: Wed, 15 Jan 2025 23:32:24 +0100 Subject: [PATCH 4/9] Update role_none_conflict_resolution.tentative.html --- .../role/role_none_conflict_resolution.tentative.html | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/wai-aria/role/role_none_conflict_resolution.tentative.html b/wai-aria/role/role_none_conflict_resolution.tentative.html index c7eb26aafac894..bf1679329cbb9c 100644 --- a/wai-aria/role/role_none_conflict_resolution.tentative.html +++ b/wai-aria/role/role_none_conflict_resolution.tentative.html @@ -27,15 +27,17 @@

HTML button nesting HTML button

From db7d40344b0e5704c0250383df0a0432f06623dd Mon Sep 17 00:00:00 2001 From: Giacomo Petri Date: Wed, 15 Jan 2025 23:35:03 +0100 Subject: [PATCH 5/9] Update role_none_conflict_resolution.tentative.html --- wai-aria/role/role_none_conflict_resolution.tentative.html | 2 ++ 1 file changed, 2 insertions(+) diff --git a/wai-aria/role/role_none_conflict_resolution.tentative.html b/wai-aria/role/role_none_conflict_resolution.tentative.html index bf1679329cbb9c..9493cfe42ca4a2 100644 --- a/wai-aria/role/role_none_conflict_resolution.tentative.html +++ b/wai-aria/role/role_none_conflict_resolution.tentative.html @@ -10,6 +10,8 @@ + +

ARIA role="button" nesting ARIA role="button" (no presentational roles conflict resolution, since not focusable)

From 767d7d1c952a6e354ceb46ebf0f40e65d3a4a3e8 Mon Sep 17 00:00:00 2001 From: Giacomo Petri Date: Fri, 17 Jan 2025 09:41:43 +0100 Subject: [PATCH 6/9] Apply suggestions from code review Co-authored-by: James Craig --- .../role/role_none_conflict_resolution.tentative.html | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/wai-aria/role/role_none_conflict_resolution.tentative.html b/wai-aria/role/role_none_conflict_resolution.tentative.html index 9493cfe42ca4a2..4bb22947a498c5 100644 --- a/wai-aria/role/role_none_conflict_resolution.tentative.html +++ b/wai-aria/role/role_none_conflict_resolution.tentative.html @@ -11,12 +11,12 @@ - +

ARIA role="button" nesting ARIA role="button" (no presentational roles conflict resolution, since not focusable)

outer button - Inner button + Inner button
@@ -33,12 +33,12 @@

HTML button nesting HTML button

const innerButton = document.createElement("button"); innerButton.textContent = " (inner button)"; innerButton.id = "inner-button"; - innerButton.classList.add("ex"); + innerButton.classList.add("ex-role"); innerButton.setAttribute('data-expectedrole','button'); innerButton.setAttribute('data-testname','JS injected HTML button within another HTML button'); document.getElementById("inner-button-container").appendChild(innerButton); - AriaUtils.verifyRolesBySelector(".ex"); + AriaUtils.verifyRolesBySelector(".ex-role"); AriaUtils.verifyGenericRolesBySelector(".ex-generic"); From ddab884e89a32e6c8903bd3480d6079b35091d54 Mon Sep 17 00:00:00 2001 From: Giacomo Petri Date: Fri, 17 Jan 2025 09:57:57 +0100 Subject: [PATCH 7/9] Update role_none_conflict_resolution.tentative.html --- ...le_none_conflict_resolution.tentative.html | 25 +++++++++++++++++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/wai-aria/role/role_none_conflict_resolution.tentative.html b/wai-aria/role/role_none_conflict_resolution.tentative.html index 4bb22947a498c5..1df292a5bda615 100644 --- a/wai-aria/role/role_none_conflict_resolution.tentative.html +++ b/wai-aria/role/role_none_conflict_resolution.tentative.html @@ -13,10 +13,31 @@ -

ARIA role="button" nesting ARIA role="button" (no presentational roles conflict resolution, since not focusable)

+

ARIA role="button" nesting ARIA role="button" (no presentational roles conflict resolution, since inner button is not focusable)

outer button - Inner button + Inner button +
+ + +

Focusable ARIA role="button" nesting non-focusable ARIA role="button" (no presentational roles conflict resolution, since inner button is not focusable)

+
+ outer button + Inner button +
+ + +

Non-focusable ARIA role="button" nesting focusable ARIA role="button" (presentational roles conflict resolution arise, since inner button is focusable)

+
+ outer button + Inner button +
+ + +

Focusable ARIA role="button" nesting focusable ARIA role="button" (presentational roles conflict resolution arise, since inner button is focusable)

+
+ outer button + Inner button
From cbd4f58b9c0baeedea798f9b15bb6f0da4c0d699 Mon Sep 17 00:00:00 2001 From: Giacomo Petri Date: Fri, 17 Jan 2025 09:59:39 +0100 Subject: [PATCH 8/9] Update role_none_conflict_resolution.tentative.html --- wai-aria/role/role_none_conflict_resolution.tentative.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wai-aria/role/role_none_conflict_resolution.tentative.html b/wai-aria/role/role_none_conflict_resolution.tentative.html index 1df292a5bda615..778a059ca606bf 100644 --- a/wai-aria/role/role_none_conflict_resolution.tentative.html +++ b/wai-aria/role/role_none_conflict_resolution.tentative.html @@ -13,7 +13,7 @@ -

ARIA role="button" nesting ARIA role="button" (no presentational roles conflict resolution, since inner button is not focusable)

+

Non-focusable ARIA role="button" nesting non-focusable ARIA role="button" (no presentational roles conflict resolution, since inner button is not focusable)

outer button Inner button From d33999c8b9fc328410b3a09d34fe62472072f8e6 Mon Sep 17 00:00:00 2001 From: Giacomo Petri Date: Tue, 21 Jan 2025 22:55:44 +0100 Subject: [PATCH 9/9] Update role_none_conflict_resolution.tentative.html --- wai-aria/role/role_none_conflict_resolution.tentative.html | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/wai-aria/role/role_none_conflict_resolution.tentative.html b/wai-aria/role/role_none_conflict_resolution.tentative.html index 778a059ca606bf..f8f7a097e7cc00 100644 --- a/wai-aria/role/role_none_conflict_resolution.tentative.html +++ b/wai-aria/role/role_none_conflict_resolution.tentative.html @@ -10,7 +10,6 @@ -

Non-focusable ARIA role="button" nesting non-focusable ARIA role="button" (no presentational roles conflict resolution, since inner button is not focusable)

@@ -55,7 +54,7 @@

HTML button nesting HTML button

innerButton.textContent = " (inner button)"; innerButton.id = "inner-button"; innerButton.classList.add("ex-role"); - innerButton.setAttribute('data-expectedrole','button'); + innerButton.setAttribute('data-expectedrole','SPEC_AMBIGUOUS_LOG_VALUE'); innerButton.setAttribute('data-testname','JS injected HTML button within another HTML button'); document.getElementById("inner-button-container").appendChild(innerButton);