Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to override the styles for the modal container #443

Closed
ericpoulinnz opened this issue Jan 19, 2025 · 7 comments
Closed

Add the ability to override the styles for the modal container #443

ericpoulinnz opened this issue Jan 19, 2025 · 7 comments
Labels
needs repro Needs reproducible example

Comments

@ericpoulinnz
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I don't like that the max height of the date picker modal is 800px. This looks terrible and is way too tall for a modal on a laptop screen.

Describe the solution you'd like
The ability to pass in a styles prop which applies on top of the modalContent style.

Describe alternatives you've considered
Seems impossible with this library?

@ericpoulinnz
Copy link
Contributor Author

Another option is to just reduce the 800px down to something which looks nicer (~600px)

@iM-GeeKy iM-GeeKy added the needs repro Needs reproducible example label Jan 19, 2025
Copy link
Contributor

Hey! Thanks for opening the issue. Can you provide a minimal repro which demonstrates the issue? Posting a snippet of your code in the issue is useful, but it's not usually straightforward to run. A repro will help us debug the issue faster. Please try to keep the repro as small as possible. The easiest way to provide a repro is on snack.expo.dev. If it's not possible to repro it on snack.expo.dev, then you can also provide the repro in a GitHub repository.

@iM-GeeKy
Copy link
Collaborator

iM-GeeKy commented Jan 19, 2025

@ericpoulinnz PRs are welcome!

@ericpoulinnz
Copy link
Contributor Author

@iM-GeeKy would you accept just changing the maxheight down to 600px? I don't have time to create a PR here for full styling control (I've just patched with my style on my end) - but if you are happy with literally changing that one style, then sure, I can make that very simple PR.

... I also noticed the 'needs repro' tag added to this issue. Here is how it looks. All the space at the bottom is odd and not standard for Material modals.

Image

@ericpoulinnz
Copy link
Contributor Author

@iM-GeeKy went ahead and created #444

I also reduced the width which looked very stretched when I was comparing to other Google products using Material design.

@iM-GeeKy
Copy link
Collaborator

@ericpoulinnz Thanks! Closing as #444 is now merged and released 0.22.29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs repro Needs reproducible example
Projects
None yet
Development

No branches or pull requests

3 participants
@ericpoulinnz @iM-GeeKy and others