Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to define min/max dates able to be selected #445

Closed
ericpoulinnz opened this issue Jan 22, 2025 · 4 comments
Closed

Ability to define min/max dates able to be selected #445

ericpoulinnz opened this issue Jan 22, 2025 · 4 comments
Labels
needs more info Needs more information needs repro Needs reproducible example

Comments

@ericpoulinnz
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Often when requiring a user to select a date, there will be a reason to enforce a minimum and/or maximum date they are allowed to select.

Describe the solution you'd like
Ability to set a minimumDate and maximumDate for the DatePicker component. Date options that fall outside the min/max dates should be disabled.

Describe alternatives you've considered
Validation after selection, but blocking this before selection would be a nicer UX.

@iM-GeeKy iM-GeeKy added needs repro Needs reproducible example needs more info Needs more information labels Jan 26, 2025
Copy link
Contributor

Hey! Thanks for opening the issue. Can you provide a minimal repro which demonstrates the issue? Posting a snippet of your code in the issue is useful, but it's not usually straightforward to run. A repro will help us debug the issue faster. Please try to keep the repro as small as possible. The easiest way to provide a repro is on snack.expo.dev. If it's not possible to repro it on snack.expo.dev, then you can also provide the repro in a GitHub repository.

Copy link
Contributor

Hey! Thanks for opening the issue. Can you provide more information about the issue? Please fill the issue template when opening the issue without deleting any section. We need all the information we can, to be able to help. Make sure to at least provide - Current behaviour, Expected behaviour, A way to reproduce the issue with minimal code (link to snack.expo.dev) or a repo on GitHub, and the information about your environment (such as the platform of the device, versions of all the packages etc.).

@ericpoulinnz
Copy link
Contributor Author

Found the validRange prop after posting this. I searched for "max" or "min" in the code/docs and didn't find anything.

Though clearly I'm not the only one confused by this (#448 is a duplicate of the same confusion). All other date libraries I have used use min/max rather than start/end as the way to define this. Might be worth mentioning this in the docs.

@Lucignation
Copy link

Seriously I think there is a need to clear that confusion but though I am using validRange, it only works for selected start date and end date not allowing the developer to set a max date so that the date after the max date is disabled for user to click.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs more info Needs more information needs repro Needs reproducible example
Projects
None yet
Development

No branches or pull requests

3 participants