Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IANA media type application/vnd.ipld.car #1206

Closed
lidel opened this issue Apr 4, 2022 · 1 comment
Closed

Use IANA media type application/vnd.ipld.car #1206

lidel opened this issue Apr 4, 2022 · 1 comment
Assignees
@olizilla
Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization

Comments

@lidel
Copy link

lidel commented Apr 4, 2022

See ipfs/in-web-browsers#192 (comment)
@lidel lidel added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Apr 4, 2022
@olizilla olizilla self-assigned this Apr 5, 2022
olizilla added a commit to storacha/ipfs-car that referenced this issue Apr 5, 2022
@olizilla
feat!: iana media type application/vnd.ipld.car
08c8511 
We now have an official IANA media type for CARs `application/vnd.ipld.car` so use it here.

see: web3-storage/web3.storage#1206
see: https://www.iana.org/assignments/media-types/application/vnd.ipld.car

License: (Apache-2.0 AND MIT)
Signed-off-by: Oli Evans <[email protected]>
@olizilla olizilla mentioned this issue Apr 5, 2022
Merged
olizilla added a commit that referenced this issue Apr 5, 2022
@olizilla
feat!: iana media type application/vnd.ipld.car
fbe3c87 
We now have an official IANA media type for CARs `application/vnd.ipld.car` so use it here.

fixes: #1206
needs: storacha/ipfs-car#119
see: https://www.iana.org/assignments/media-types/application/vnd.ipld.car

License: (Apache-2.0 AND MIT)
Signed-off-by: Oli Evans <[email protected]>
@olizilla olizilla mentioned this issue Apr 5, 2022
Merged
vasco-santos pushed a commit to storacha/ipfs-car that referenced this issue Apr 5, 2022
@olizilla
feat!: iana media type application/vnd.ipld.car (#119)
739c00d 
We now have an official IANA media type for CARs `application/vnd.ipld.car` so use it here.

see: web3-storage/web3.storage#1206
see: https://www.iana.org/assignments/media-types/application/vnd.ipld.car

License: (Apache-2.0 AND MIT)
Signed-off-by: Oli Evans <[email protected]>
@olizilla
Copy link
Contributor

olizilla commented Apr 7, 2022

[email protected] is released with the new iana media type set to application/vnd.ipld.car when packing to a Blob

#1215 updates our api and client to use the new mediat type. That PR will need to be merged and the client and api released before we can update the w3 cli and website transitive dep on [email protected] via the previous release of the web3.storage client. A follow up PR will be submitted once web3.storage is updated on npm with the change.

olizilla added a commit to storacha/w3ui that referenced this issue Feb 6, 2023
@olizilla
fix: use correct IANA media type
f0a3b7d 
see: web3-storage/web3.storage#1206

License: MIT
Signed-off-by: Oli Evans <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olizilla olizilla

Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@olizilla @lidel